Skip to content

[ISSUE #1382]Only send back part of messages by setting ackIndex#1385

Closed
AbelSara wants to merge 1 commit into
apache:developfrom
AbelSara:master
Closed

[ISSUE #1382]Only send back part of messages by setting ackIndex#1385
AbelSara wants to merge 1 commit into
apache:developfrom
AbelSara:master

Conversation

@AbelSara
Copy link
Copy Markdown

What is the purpose of the change

Set ackIndex by yourself when consumeMessage return RECONSUME_LATER.
#1382

Brief changelog

XX

Verifying this change

If consumeMessage pull a batch of messages and one of them throw an exception, consumeMessage will return RECONSUME_LATER. ConsumeMessageCurrentlyService will receive this status, and send back this batch of messages. If you want to control number of messages that should be sent back, you can set ackIndex property by consumer.setAckIndex(index). Actually, if you still want old feature, don't use consumer.setAckIndex().

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky added the type/wontfix Stale over 3 months, or its not a rational problem. leaving it to close label Aug 14, 2019
@vongosling vongosling closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/wontfix Stale over 3 months, or its not a rational problem. leaving it to close

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants