[ROCKETMQ-253]Compress RegisterBrokerBody#140
Closed
lizhanhui wants to merge 4 commits intoapache:developfrom
Closed
[ROCKETMQ-253]Compress RegisterBrokerBody#140lizhanhui wants to merge 4 commits intoapache:developfrom
lizhanhui wants to merge 4 commits intoapache:developfrom
Conversation
Contributor
|
Wonderfull,it's a good idea to make package smaller. |
Contributor
Author
|
@lindzh Welcome to review this PR. |
shroman
reviewed
Aug 9, 2017
| requestBody.setTopicConfigSerializeWrapper(topicConfigWrapper); | ||
| requestBody.setFilterServerList(filterServerList); | ||
| request.setBody(requestBody.encode()); | ||
| request.setBody(requestBody.encode(true)); |
Contributor
There was a problem hiding this comment.
Great idea!
How about setting a threshold for compression being triggered, because if the data you compress is small, it overhead is higher than the benefits you get from the compression?
shroman
reviewed
Aug 9, 2017
| } | ||
|
|
||
| ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); | ||
| DeflaterOutputStream outputStream = new DeflaterOutputStream(byteArrayOutputStream, new Deflater(Deflater.BEST_COMPRESSION)); |
Contributor
There was a problem hiding this comment.
I think Deflater.BEST_COMPRESSION may be even slower than GZIP. Do we care about compression speed?
Member
|
I will close the pr, if you happened to the same question, please let me know. |
pingww
added a commit
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the description part of this issue please.