[ISSUE #1397]Add abnormal recover for dleger modle #1405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duhenglucky
changed the title
RongtongJin
reviewed
Aug 26, 2019
| long mappedFileOffset = 0; | ||
| while (true) { | ||
| DispatchRequest dispatchRequest = this.checkMessageAndReturnSize(byteBuffer, checkCRCOnRecover); | ||
| int size = dispatchRequest.getMsgSize(); |
Contributor
There was a problem hiding this comment.
This size does not contain dledger header, causing the processOffset to be wrong. Maybe should add DLedgerEntry.BODY_OFFSET.
| } | ||
| //Indicate that, it is the first time to load mixed commitlog, need to recover the old commitlog | ||
| isInrecoveringOldCommitlog = true; | ||
| //No need the abnormal recover |
Contributor
There was a problem hiding this comment.
Comment and code are inconsistent.
| } | ||
|
|
||
| private void recover(long maxPhyOffsetOfConsumeQueue) { | ||
| private void recoverDlegerAbnormally(long maxPhyOffsetOfConsumeQueue) { |
vongosling
approved these changes
Aug 30, 2019
Contributor
|
I'm sry but is this patch merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add abnormal recover for dleger modle， fix the issue 1397
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.