Skip to content

Fix offset maybe lost problem.#1427

Closed
aftersss wants to merge 3 commits into
apache:developfrom
aftersss:master_fix_offset_maybe_loss
Closed

Fix offset maybe lost problem.#1427
aftersss wants to merge 3 commits into
apache:developfrom
aftersss:master_fix_offset_maybe_loss

Conversation

@aftersss
Copy link
Copy Markdown

If two clients commit offset at the same time(the same topic and group, but different queueId), one of the queue's offset maybe lost.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 29, 2019

Coverage Status

Coverage increased (+0.06%) to 50.55% when pulling bf459e5 on aftersss:master_fix_offset_maybe_loss into 63f18c9 on apache:develop.

@vongosling vongosling force-pushed the master branch 3 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
@xiangwangcheng
Copy link
Copy Markdown

Thanks for your contribution!
The code LGTM.
But could u please change the destination branch to develop add some unit test to increase the coverage?

@aftersss aftersss changed the base branch from master to develop October 28, 2019 08:18
@aftersss
Copy link
Copy Markdown
Author

Thanks for your contribution!
The code LGTM.
But could u please change the destination branch to develop add some unit test to increase the coverage?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants