Skip to content

[ISSUE #1456]Fix replica abnormal recover slow issue#1455

Merged
vongosling merged 2 commits intoapache:developfrom
duhenglucky:slave_recover_slow
Sep 17, 2019
Merged

[ISSUE #1456]Fix replica abnormal recover slow issue#1455
vongosling merged 2 commits intoapache:developfrom
duhenglucky:slave_recover_slow

Conversation

@duhenglucky
Copy link
Contributor

@duhenglucky duhenglucky commented Sep 16, 2019

What is the purpose of the change

Fix replica recover slow issue

Brief changelog

In the current design, there is no way to update the Checkpoint PhysicMsgTimestamp for replica server, so the update logic for PhysicMsgTimestamp is added to the Reput logic.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky changed the title Fix slave recover slow issue [ISSUE #1456]Fix slave recover slow issue Sep 16, 2019
@coveralls
Copy link

coveralls commented Sep 16, 2019

Coverage Status

Coverage decreased (-0.04%) to 49.497% when pulling f590bd5 on duhenglucky:slave_recover_slow into faef364 on apache:develop.

@duhenglucky duhenglucky changed the title [ISSUE #1456]Fix slave recover slow issue [ISSUE #1456]Fix slave abnormal recover slow issue Sep 16, 2019
@duhenglucky duhenglucky added this to the 4.6.0 milestone Sep 16, 2019
@vongosling vongosling changed the title [ISSUE #1456]Fix slave abnormal recover slow issue [ISSUE #1456]Fix replica abnormal recover slow issue Sep 17, 2019
@vongosling vongosling merged commit 523b60c into apache:develop Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants