modify loginfo when visiting namesrv#1478
Closed
keranbingaa wants to merge 2 commits into
Closed
Conversation
Contributor
|
@keranbingaa address seems more clear than the channel, IMHO, print all channel info isn't a good choice in here. |
Contributor
Author
|
@duhenglucky I modify what print out， and now it just print the address, and when the variable address is null, it will also print the remote address. |
Contributor
|
I think printing address is more clear too.And just printing channel.remoteAddress() will be ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
work for this issue, the loginfo is ambiguity when visiting namesrv, so we modify the loginfo to make it clear.
Brief changelog
use the variable channel to replace addr in the log statement.