Skip to content

remove unnecessary symbol filelock in IndexFile.java#1509

Closed
luxward wants to merge 1 commit into
apache:developfrom
luxward:remove_symbol
Closed

remove unnecessary symbol filelock in IndexFile.java#1509
luxward wants to merge 1 commit into
apache:developfrom
luxward:remove_symbol

Conversation

@luxward
Copy link
Copy Markdown

@luxward luxward commented Oct 8, 2019

What is the purpose of the change

trivial cleanups: remove unnecessary symbol filelock in IndexFile.java

Brief changelog

remove unnecessary symbol filelock in IndexFile.java, only remain annotation for intention of this symbol

Verifying this change

simple code review

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 49.408% when pulling 1db828f on luxward:remove_symbol into 430c62e on apache:develop.

@luxward
Copy link
Copy Markdown
Author

luxward commented Oct 9, 2019

@zhouxinyu please help me review this code. However, result of code checking is straight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants