fix async invoke timeout is not accurate#1632
Closed
liyiwen3 wants to merge 1 commit into
Closed
Conversation
|
Author
Yes,of course,done |
Author
|
Yes of course,I have changed the destination branch to devleop.
…------------------ 原始邮件 ------------------
发件人: "程向往"<notifications@github.com>;
发送时间: 2019年12月11日(星期三) 上午9:48
收件人: "apache/rocketmq"<rocketmq@noreply.github.com>;
抄送: "915071628"<915071628@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/rocketmq] fix async invoke timeout is not accurate (#1632)
The scanResponseTable() method is invoked periodically(every one second), it could be late for one second for one particular reponseFuture to be scanned, in the worst case. So
(rep.getBeginTimestamp() + rep.getTimeoutMillis() + 1000) <= System.currentTimeMillis()
does mean something.
Could you please change the destination branch to devleop?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
It is a bug that invokeAsync's timeout have not been handled accurately
Brief changelog
fix async invoke timeout is not accurate