Skip to content

fix async invoke timeout is not accurate#1632

Closed
liyiwen3 wants to merge 1 commit into
apache:developfrom
liyiwen3:dev
Closed

fix async invoke timeout is not accurate#1632
liyiwen3 wants to merge 1 commit into
apache:developfrom
liyiwen3:dev

Conversation

@liyiwen3
Copy link
Copy Markdown

@liyiwen3 liyiwen3 commented Dec 1, 2019

What is the purpose of the change

It is a bug that invokeAsync's timeout have not been handled accurately

Brief changelog

fix async invoke timeout is not accurate

@xiangwangcheng
Copy link
Copy Markdown

  1. The scanResponseTable() method is invoked periodically(every one second), it could be late for one second for one particular reponseFuture to be scanned, in the worst case. So
    (rep.getBeginTimestamp() + rep.getTimeoutMillis() + 1000) <= System.currentTimeMillis()
    does mean something.

  2. Could you please change the destination branch to devleop?

@liyiwen3 liyiwen3 changed the base branch from master to develop December 11, 2019 03:36
@liyiwen3
Copy link
Copy Markdown
Author

  1. The scanResponseTable() method is invoked periodically(every one second), it could be late for one second for one particular reponseFuture to be scanned, in the worst case. So
    (rep.getBeginTimestamp() + rep.getTimeoutMillis() + 1000) <= System.currentTimeMillis()
    does mean something.
  2. Could you please change the destination branch to devleop?

Yes,of course,done

@liyiwen3
Copy link
Copy Markdown
Author

liyiwen3 commented Dec 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants