Skip to content

Conversation

@duhenglucky
Copy link
Contributor

fix(transaction) fix the send back message sent into transaction half topic referred in this issue.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 50.553% when pulling 118bf22 on duhenglucky:fix_transaction_sendback into f8f6fbe on apache:develop.

@xiangwangcheng
Copy link

Do we need modify sendMessageBack method of DefaultMQPullConsumerImpl too?
image

@duhenglucky
Copy link
Contributor Author

Do we need modify sendMessageBack method of DefaultMQPullConsumerImpl too?
image
DefaultMQPullConsumerImpl has been deprecated for months ago, and actually only upgrades the broker can also prevent this issue occurred, and the push consumer is repaired to ensure that this issue can still be avoided without upgrading the server.

@duhenglucky duhenglucky merged commit ad7622c into apache:develop Jan 10, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants