Skip to content

[ISSUE #1678] Use thread safe CopyOnWriteArrayList for registerBrokerResultList#1753

Merged
RongtongJin merged 1 commit intoapache:developfrom
lich0079:issue_1678
Dec 4, 2020
Merged

[ISSUE #1678] Use thread safe CopyOnWriteArrayList for registerBrokerResultList#1753
RongtongJin merged 1 commit intoapache:developfrom
lich0079:issue_1678

Conversation

@lich0079
Copy link
Copy Markdown
Contributor

@lich0079 lich0079 commented Feb 1, 2020

What is the purpose of the change

registerBrokerResultList will invoke add in separate threads, therefore it's not safe to use ArrayList, fix #1678

Brief changelog

Follow existing code pattern https://github.com/apache/rocketmq/blob/master/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java#L268
to use thread-safe CopyOnWriteArrayList

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lich0079 lich0079 closed this Feb 2, 2020
@lich0079 lich0079 reopened this Feb 2, 2020
@xujianhai666
Copy link
Copy Markdown
Member

@lich0079 ci failed, more info /home/travis/build/apache/rocketmq/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java:19:8: error: Unused import - com.google.common.collect.Lists.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 50.901% when pulling 804c189 on lich0079:issue_1678 into 997164b on apache:develop.

@lich0079
Copy link
Copy Markdown
Contributor Author

lich0079 commented Mar 2, 2020

@xujianhai666 code updated, please check.

@RongtongJin RongtongJin added this to the 4.8.0 milestone Mar 12, 2020
@RongtongJin RongtongJin merged commit 7f49ce4 into apache:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants