[ISSUE #1904] Print log when flush timeout#1903
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1903 +/- ##
==========================================
Coverage ? 45.10%
Complexity ? 4198
==========================================
Files ? 544
Lines ? 35732
Branches ? 4746
==========================================
Hits ? 16116
Misses ? 17566
Partials ? 2050 Continue to review full report at Codecov.
|
ShannonDing
changed the title
|
It seems to conflict with #1894, could you please check again? |
| if (flushStatus != PutMessageStatus.PUT_OK) { | ||
| putMessageResult.setPutMessageStatus(PutMessageStatus.FLUSH_DISK_TIMEOUT); | ||
| putMessageResult.setPutMessageStatus(flushStatus); | ||
| log.error("do groupcommit, wait for flush failed, topic: {} tags: {} client address: {}", |
There was a problem hiding this comment.
If the disk flashing has failed, and continue to log here, it will increase the system load and increase disk IO.
IMO, as the status will be sent to the client, it is better to remove the error log here.
There was a problem hiding this comment.
Indeed so.
I still have a question about [#1894 pr]
req.wakeupCustomer(flushOK ? PutMessageStatus.PUT_OK : PutMessageStatus.FLUSH_DISK_TIMEOUT);flushOK is false means FLUSH_DISK_TIMEOUT?
|
Need to associate with milestone :-) @RongtongJin |
* rollback my code * avoid log when disk flush * when msg is in next file, flushOK value may be wrong
* rollback my code * avoid log when disk flush * when msg is in next file, flushOK value may be wrong
7 participants
What is the purpose of the change
Print log when flush timeout