Skip to content

[ISSUE #1653] Support OpenMessaging pubsub mode#1913

Closed
duhenglucky wants to merge 10 commits intoapache:developfrom
duhenglucky:openmessaging-pubsub
Closed

[ISSUE #1653] Support OpenMessaging pubsub mode#1913
duhenglucky wants to merge 10 commits intoapache:developfrom
duhenglucky:openmessaging-pubsub

Conversation

@duhenglucky
Copy link
Contributor

@duhenglucky duhenglucky commented Apr 2, 2020

What is the purpose of the change

Support for the OpenMessaging pubsub model is provided

【DISCUSS】
Should we override the previous openmessaging implementation as it was only an alpha release?

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky linked an issue Apr 2, 2020 that may be closed by this pull request
@duhenglucky duhenglucky changed the title Openmessaging pubsub support [ISSUE #1653]Openmessaging pubsub support Apr 2, 2020
@duhenglucky duhenglucky added this to the 4.8.0 milestone Apr 2, 2020
@duhenglucky duhenglucky changed the title [ISSUE #1653]Openmessaging pubsub support [ISSUE #1653]OpenMessaging pubsub support Apr 2, 2020
@coveralls
Copy link

coveralls commented Apr 2, 2020

Coverage Status

Coverage decreased (-0.08%) to 50.837% when pulling 5a2ea6b on duhenglucky:openmessaging-pubsub into 0a9822e on apache:develop.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@1558e05). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1913   +/-   ##
==========================================
  Coverage           ?   45.13%           
  Complexity         ?     4191           
==========================================
  Files              ?      543           
  Lines              ?    35715           
  Branches           ?     4743           
==========================================
  Hits               ?    16119           
  Misses             ?    17546           
  Partials           ?     2050           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1558e05...5a2ea6b. Read the comment docs.

@RongtongJin RongtongJin changed the title [ISSUE #1653]OpenMessaging pubsub support [ISSUE #1653] OpenMessaging pubsub support Jun 30, 2020
@RongtongJin RongtongJin changed the title [ISSUE #1653] OpenMessaging pubsub support [ISSUE #1653] Support openMessaging pubsub mode Jun 30, 2020
@RongtongJin RongtongJin changed the title [ISSUE #1653] Support openMessaging pubsub mode [ISSUE #1653] Support OpenMessaging pubsub mode Jun 30, 2020
@RongtongJin RongtongJin modified the milestones: 4.8.0, 4.9.0 Dec 4, 2020
@github-actions
Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jul 25, 2023
@github-actions
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request OpenMessaging latest version support

5 participants