Skip to content

Conversation

@ifplusor
Copy link
Contributor

@ifplusor ifplusor commented Apr 15, 2020

What is the purpose of the change

Fixed typo in RequestResponseFuture.

Brief changelog

rename RequestResponseFuture.setSendReqeustOk to RequestResponseFuture.setSendRequestOk.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

rename RequestResponseFuture.setSendReqeustOk to
RequestResponseFuture.setSendRequestOk.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 50.875% when pulling 78b6d7b on ifplusor:fixed-typo-in-RequestResponseFuture into 8ef01a6 on apache:master.

@ifplusor ifplusor requested a review from duhenglucky April 15, 2020 04:51
@duhenglucky duhenglucky changed the base branch from master to develop April 15, 2020 04:53
Copy link
Contributor

@wlliqipeng wlliqipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wlliqipeng wlliqipeng merged commit 1706cec into apache:develop Apr 16, 2020
@ifplusor ifplusor deleted the fixed-typo-in-RequestResponseFuture branch April 16, 2020 06:33
@RongtongJin RongtongJin linked an issue May 25, 2020 that may be closed by this pull request
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…ponseFuture

Fixed typo in RequestResponseFuture.
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
…ponseFuture

Fixed typo in RequestResponseFuture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo error in RequestResponseFuture

5 participants