Skip to content

Conversation

@RealBar
Copy link
Contributor

@RealBar RealBar commented May 31, 2020

use "$@" instead of #@ to make mutiple value parceled by quoted
available.

What is the purpose of the change

fix issue 1988
#1988

Brief changelog

use "$@" instead of #@ to make mutiple value parceled by quoted
available.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

use "$@" instead of #@ to make mutiple value parceled by quoted
available.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 50.919% when pulling 47b22ec on RealBar:fix/issue1988 into 8ef01a6 on apache:master.

@RongtongJin RongtongJin changed the title fix: fix issue #1988 [ISSUE #1988] Fix the issue that can not update messageDelay correctly with mqadmin updateBrokerConfig command Jun 1, 2020
Copy link

@geektcp geektcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vongosling vongosling added this to the 4.7.1 milestone Jun 2, 2020
@vongosling vongosling merged commit 03e8b03 into apache:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can not update messageDelay correctly with mqadmin updateBrokerConfig command

4 participants