[ISSUE #2082] Use StringBuilder instead of StringBuffer.#2087
Merged
Conversation
added 2 commits
June 11, 2020 10:32
Codecov Report
@@ Coverage Diff @@
## develop #2087 +/- ##
=============================================
+ Coverage 45.07% 45.40% +0.32%
- Complexity 4195 4241 +46
=============================================
Files 545 545
Lines 35728 35843 +115
Branches 4744 4762 +18
=============================================
+ Hits 16103 16273 +170
+ Misses 17576 17520 -56
- Partials 2049 2050 +1
Continue to review full report at Codecov.
|
lizhiboo
approved these changes
Jun 11, 2020
ShannonDing
approved these changes
Jun 12, 2020
ShannonDing
changed the title
RongtongJin
approved these changes
Jun 15, 2020
RongtongJin
pushed a commit
that referenced
this pull request
Jun 24, 2020
tandan330
pushed a commit
to tandan330/rocketmq
that referenced
this pull request
Jun 29, 2020
* ORIGN-develop: (326 commits) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release rocketmq-all-4.7.1 chore(release):prepare to release RocketMQ 4.7.1 [ISSUE apache#2118] Fix AdminBrokerProcessorTest can not pass when machine's hostname contains illegal characters [ISSUE apache#2088] Optimize rocketmq client's stats of RT to make sense [ISSUE apache#2082] Use StringBuilder instead of StringBuffer. (apache#2087) [ISSUE apache#2085]support graceful shutdown push consumer (apache#2084) [ISSUE#2078] HmacSHA1 not avaliable when use openjdk [ISSUE apache#1976]System topic should add permission checking globally (apache#1985) [ISSUE apache#1931] Remove duplicated doAfterRpcHooks logic [ISSUE apache#2044] Fix DefaultLitePullConsumerImpl NPE (apache#2059) Fix Fastjson version for RCE problem [ISSUE apache#1988] Fix the issue that can not update messageDelay correctly with mqadmin updateBrokerConfig command Add @OverRide for RMQOrderListener.java (apache#1939) Init english version of the README Fix typo in README select a new namesrv when namesrvAddrChoosed not in new addr list npe fix comment fix [ISSUE apache#1689]add interfaces to remove unused statsItems in BrokerStatsManager. (apache#2029) ... # Conflicts: # client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyServiceTest.java
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…e#2087) * stringbuilder replace Co-authored-by: qunlin.yi <qunlin.yi@beibei.com>
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
…e#2087) * stringbuilder replace Co-authored-by: qunlin.yi <qunlin.yi@beibei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
replace StringBuffer to StringBulder
Brief changelog
replace StringBuffer to StringBulder
Verifying this change
replace StringBuffer to StringBulder
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.