Skip to content

[ISSUE #2067] Add logs when collecting disk space usage#2116

Merged
RongtongJin merged 1 commit into
apache:developfrom
imaffe:affe-0623-#2067-addlogs-disk-usage
Aug 11, 2020
Merged

[ISSUE #2067] Add logs when collecting disk space usage#2116
RongtongJin merged 1 commit into
apache:developfrom
imaffe:affe-0623-#2067-addlogs-disk-usage

Conversation

@imaffe
Copy link
Copy Markdown
Contributor

@imaffe imaffe commented Jun 23, 2020

What is the purpose of the change

  1. issue logics disk maybe full soon, so reclaim space, -1.0 #2067 , need more detailed log to find why the path is invalid.

Brief changelog

  1. added 3 log statement

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 23, 2020

Coverage Status

Coverage increased (+0.07%) to 50.92% when pulling c3e2958 on imaffe:affe-0623-#2067-addlogs-disk-usage into e923a35 on apache:master.

Comment thread common/src/main/java/org/apache/rocketmq/common/UtilAll.java Outdated
Comment thread common/src/main/java/org/apache/rocketmq/common/UtilAll.java Outdated
…od should be more robust and should fail or throw exception
@imaffe imaffe force-pushed the affe-0623-#2067-addlogs-disk-usage branch from b32dbc4 to c3e2958 Compare June 24, 2020 04:07
@RongtongJin RongtongJin changed the title [ISSUE #2067] add logs when collecting disk space usage [ISSUE #2067] Add logs when collecting disk space usage Jun 30, 2020
@RongtongJin RongtongJin changed the base branch from master to develop June 30, 2020 11:53
@RongtongJin RongtongJin merged commit a093f8a into apache:develop Aug 11, 2020
@imaffe imaffe added this to the 4.8.0 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants