Skip to content

Conversation

@lindzh
Copy link
Contributor

@lindzh lindzh commented Jan 11, 2018

What is the purpose of the change

In some cases , we want to send message menually to a specified topic in product environment , such as DLQ resend, we have to write code and publish. In my opinion , sendMessage command is commonly used in such cases.

Brief changelog

Add SendMessageCommand

Verifying this change

This is a trivial change.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

lindzh added 17 commits August 11, 2017 15:55
@lindzh lindzh changed the base branch from master to develop January 11, 2018 06:35
Copy link
Contributor

@shroman shroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

import org.apache.rocketmq.tools.command.SubCommandException;

public class DecodeMessageIdCommond implements SubCommand {
public class DecodeMessageIdCommand implements SubCommand {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

opt.setRequired(true);
options.addOption(opt);

opt = new Option("b", "body", true, "message body string utf-8 format");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utf-8 string format of the message body

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

opt.setRequired(false);
options.addOption(opt);

opt = new Option("q", "qbroker", true, "send message to which broker");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q is not a good abbreviation for broker

@coveralls
Copy link

coveralls commented Jan 22, 2018

Coverage Status

Coverage increased (+0.06%) to 40.023% when pulling ea5f15b on lindzh:tools_sendmsg into a096580 on apache:develop.

@jisumanbu
Copy link

Glad to see this new feature.

@Hellojungle
Copy link
Contributor

Hellojungle commented Jun 4, 2018

I have made a new pull request to add SendMessageCommand and ConsumeMessageCommand base on this PR #332 [ROCKETMQ-353] Add sendMessageCommand and consumeMessageCommand

@vongosling vongosling closed this Jun 5, 2018
@vongosling
Copy link
Member

thanks @lindzh @what-a-good-jungle I will help you to polish the PR :-)

lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
Issue apache#217 Add a property to set callback executor thread nums

Issue apache#217 Add a property to set callback executor thread nums

See merge request !49
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants