-
Notifications
You must be signed in to change notification settings - Fork 12k
[ROCKETMQ-353] Add SendMessage Command #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shroman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| import org.apache.rocketmq.tools.command.SubCommandException; | ||
|
|
||
| public class DecodeMessageIdCommond implements SubCommand { | ||
| public class DecodeMessageIdCommand implements SubCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
| opt.setRequired(true); | ||
| options.addOption(opt); | ||
|
|
||
| opt = new Option("b", "body", true, "message body string utf-8 format"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utf-8 string format of the message body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
| opt.setRequired(false); | ||
| options.addOption(opt); | ||
|
|
||
| opt = new Option("q", "qbroker", true, "send message to which broker"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q is not a good abbreviation for broker
|
Glad to see this new feature. |
|
I have made a new pull request to add SendMessageCommand and ConsumeMessageCommand base on this PR #332 [ROCKETMQ-353] Add sendMessageCommand and consumeMessageCommand |
|
thanks @lindzh @what-a-good-jungle I will help you to polish the PR :-) |
Issue apache#217 Add a property to set callback executor thread nums Issue apache#217 Add a property to set callback executor thread nums See merge request !49
…ing to client module
What is the purpose of the change
In some cases , we want to send message menually to a specified topic in product environment , such as DLQ resend, we have to write code and publish. In my opinion , sendMessage command is commonly used in such cases.
Brief changelog
Add SendMessageCommand
Verifying this change
This is a trivial change.
Follow this checklist to help us incorporate your contribution quickly and easily:
[ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.