Skip to content

Conversation

@Hellojungle
Copy link
Contributor

@Hellojungle Hellojungle commented Jun 4, 2018

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

In some cases, sending a message to a specific topic manually is a kind of effective testing methods, so does the consuming message from the specific topic. So, I think add the two command is useful.

Brief changelog

Add sendMessageCommand and consumeMessageCommand.

Verifying this change

This is a trivial change.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Hellojungle
Copy link
Contributor Author

Hellojungle commented Jun 4, 2018

#217 [ROCKETMQ-353] Add SendMessage Command

@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage decreased (-0.007%) to 41.407% when pulling 499f7eb on what-a-good-jungle:addSendandConsumeCommand into 94f3b5a on apache:develop.

@vsair
Copy link
Contributor

vsair commented Jun 28, 2018

Admin command checkMsgSendRT is already exist, am I right?

@Hellojungle
Copy link
Contributor Author

@vsair Yes,admin command checkMsgSendRT is already exist, but this two can be more flexible

Copy link
Member

@vongosling vongosling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vongosling vongosling merged commit b75af6b into apache:develop Jul 14, 2018
@vongosling vongosling added this to the 4.3.0 milestone Jul 17, 2018
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants