[ISSUE #2241] Reinforcement hook implementation to support abort processing #2243
Closed
imaffe wants to merge 7 commits intoapache:developfrom
Closed
[ISSUE #2241] Reinforcement hook implementation to support abort processing #2243imaffe wants to merge 7 commits intoapache:developfrom
imaffe wants to merge 7 commits intoapache:developfrom
Conversation
imaffe
force-pushed
the
affe-0812-chepick
branch
2 times, most recently
from
5c20794 to
8f62e74
Compare
RongtongJin
reviewed
Aug 12, 2020
Contributor
RongtongJin
left a comment
RongtongJin
left a comment
There was a problem hiding this comment.
It would be better to add some UTs to verify correctness
broker/src/main/java/org/apache/rocketmq/broker/hook/AbortProcessException.java
Outdated
Show resolved
Hide resolved
Comment on lines
631
to
632
| case ResponseCode.FLOW_CONTROL: | ||
| break; |
Contributor
There was a problem hiding this comment.
This break can only jump out of the switch but not out of the for loop
broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
Show resolved
Hide resolved
Contributor
|
Plz pass the CI |
RongtongJin
changed the title
imaffe
force-pushed
the
affe-0812-chepick
branch
from
8f62e74 to
6ef4580
Compare
imaffe
force-pushed
the
affe-0812-chepick
branch
from
58559b5 to
b4937a6
Compare
RongtongJin
approved these changes
Aug 13, 2020
imaffe
force-pushed
the
affe-0812-chepick
branch
from
b4937a6 to
79270c3
Compare
…kage for compatibility issues
RongtongJin
approved these changes
Aug 14, 2020
imaffe
force-pushed
the
affe-0812-chepick
branch
from
d58b5c2 to
171716a
Compare
RongtongJin
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE REQUEST
Currently the broker hooks resides in mqtrace package, which doesn't describe hook's general usage. We need to refactor them to a different subpackage
We need to make hooks be able to interrupt the sending/consume process, by return early with error messages.