Skip to content

[ISSUE #2280] Disk ratio return -1.0 when cluster deployed on DLedger mode#2281

Merged
RongtongJin merged 1 commit intoapache:developfrom
maixiaohai:dledger/fix_disk_ratio_return_wrong
Sep 4, 2020
Merged

[ISSUE #2280] Disk ratio return -1.0 when cluster deployed on DLedger mode#2281
RongtongJin merged 1 commit intoapache:developfrom
maixiaohai:dledger/fix_disk_ratio_return_wrong

Conversation

@maixiaohai
Copy link
Copy Markdown
Contributor

@maixiaohai maixiaohai commented Aug 31, 2020

What is the purpose of the change

issue #2280

Brief changelog

Fix commit log path not exists

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@maixiaohai maixiaohai changed the title Disk ratio return -1.0 When cluster deployed on DLedger mode [ISSUE #2280]Disk ratio return -1.0 When cluster deployed on DLedger mode Aug 31, 2020
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 51.32% when pulling 3583df8 on maixiaohai:dledger/fix_disk_ratio_return_wrong into 9f95a97 on apache:master.

@RongtongJin RongtongJin changed the base branch from master to develop August 31, 2020 11:10
@RongtongJin RongtongJin added this to the 4.8.0 milestone Aug 31, 2020
@RongtongJin RongtongJin changed the title [ISSUE #2280]Disk ratio return -1.0 When cluster deployed on DLedger mode [ISSUE #2280] Disk ratio return -1.0 when cluster deployed on DLedger mode Sep 4, 2020
@RongtongJin RongtongJin merged commit 2f14aa5 into apache:develop Sep 4, 2020
@maixiaohai maixiaohai deleted the dledger/fix_disk_ratio_return_wrong branch September 4, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants