Skip to content

[ISSUE #XXXX] Modify cn RocketMQ_Example.md#2299

Closed
yazong wants to merge 1 commit intoapache:developfrom
yazong:master
Closed

[ISSUE #XXXX] Modify cn RocketMQ_Example.md#2299
yazong wants to merge 1 commit intoapache:developfrom
yazong:master

Conversation

@yazong
Copy link
Copy Markdown
Contributor

@yazong yazong commented Sep 12, 2020

What is the purpose of the change

Symbol error in Chinese document

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 51.255% when pulling 51c9189 on yazong:master into 9f95a97 on apache:master.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2299 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2299      +/-   ##
============================================
- Coverage     45.68%   45.43%   -0.25%     
+ Complexity     4269     4249      -20     
============================================
  Files           546      546              
  Lines         35860    35860              
  Branches       4763     4763              
============================================
- Hits          16381    16293      -88     
- Misses        17434    17516      +82     
- Partials       2045     2051       +6     
Impacted Files Coverage Δ Complexity Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) 16.00% <0.00%> (-3.00%)
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-8.89%) 8.00% <0.00%> (-2.00%)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 75.00% <0.00%> (-7.70%) 10.00% <0.00%> (-1.00%)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.98% <0.00%> (-6.50%) 16.00% <0.00%> (-3.00%)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) 7.00% <0.00%> (-1.00%)
...ain/java/org/apache/rocketmq/test/util/MQWait.java 43.24% <0.00%> (-5.41%) 3.00% <0.00%> (ø%)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 57.67% <0.00%> (-5.12%) 31.00% <0.00%> (-1.00%)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 50.99% <0.00%> (-4.39%) 34.00% <0.00%> (-2.00%)
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) 5.00% <0.00%> (-1.00%)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) 14.00% <0.00%> (-1.00%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f95a97...51c9189. Read the comment docs.

@RongtongJin
Copy link
Copy Markdown
Contributor

@yazong Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
Second, you need change the target branch to develop.

@RongtongJin RongtongJin changed the base branch from master to develop September 15, 2020 06:20
@RongtongJin RongtongJin changed the title Modify cn RocketMQ_Example.md [ISSUE #XXXX] Modify cn RocketMQ_Example.md Sep 15, 2020
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants