[ISSUE #2219] Add some asynchronous API for batch messages#2315
Merged
Conversation
zongtanghu
reviewed
Sep 21, 2020
Comment on lines
+272
to
+273
| producer.send(msgs, new MessageQueue(), sendCallback); | ||
| producer.send(msgs, new MessageQueue(), sendCallback, 1000); |
Contributor
There was a problem hiding this comment.
I have a question, here you can add another test case to coverage the case which send message successfully based on the specified message queue.
RongtongJin
approved these changes
Sep 21, 2020
Contributor
|
LGTM |
zongtanghu
approved these changes
Sep 25, 2020
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…che#2315) * [ISSUE apache#2219] Add asynchronous batch send method. * modify the ut Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
…che#2315) * [ISSUE apache#2219] Add asynchronous batch send method. * modify the ut Co-authored-by: zhangjidi2016 <zhangjidi@cmss.chinamobile.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add some asynchronous API for batch messages
Brief changelog
Add some asynchronous API for batch messages
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.