Skip to content

broker runtimeInfo add mmapFiles details#2364

Closed
makabakaboom wants to merge 4 commits into
apache:developfrom
makabakaboom:patch-1
Closed

broker runtimeInfo add mmapFiles details#2364
makabakaboom wants to merge 4 commits into
apache:developfrom
makabakaboom:patch-1

Conversation

@makabakaboom
Copy link
Copy Markdown
Contributor

@makabakaboom makabakaboom commented Oct 20, 2020

add mmapFiles details to query

What is the purpose of the change

broker runtimeInfo add mmapFiles details

Brief changelog

runtimeInfo.put("totalMappedFiles", String.valueOf(MappedFile.getTotalMappedFiles()));
runtimeInfo.put("totalMappedVirtualMemory", String.valueOf(MappedFile.getTotalMappedVirtualMemory()));

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

add mmapFiles details to query
add MappedFile import
@makabakaboom makabakaboom changed the title Update AdminBrokerProcessor.java broker runtimeInfo add mmapFiles details Oct 20, 2020
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-9.0e-05%) to 51.475% when pulling 7b76d71 on davidpdw:patch-1 into 3be7033 on apache:develop.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2364 into develop will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2364      +/-   ##
=============================================
+ Coverage      45.65%   45.69%   +0.04%     
- Complexity      4288     4293       +5     
=============================================
  Files            547      547              
  Lines          35979    35981       +2     
  Branches        4773     4773              
=============================================
+ Hits           16425    16441      +16     
+ Misses         17484    17473      -11     
+ Partials        2070     2067       -3     
Impacted Files Coverage Δ Complexity Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 7.96% <0.00%> (-0.02%) 13.00 <0.00> (ø)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.98% <0.00%> (-3.98%) 16.00% <0.00%> (-3.00%)
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) 29.00% <0.00%> (-1.00%)
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 59.18% <0.00%> (-1.03%) 11.00% <0.00%> (-1.00%)
.../rocketmq/client/impl/consumer/PullAPIWrapper.java 50.42% <0.00%> (-0.86%) 12.00% <0.00%> (-1.00%)
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 73.60% <0.00%> (-0.51%) 17.00% <0.00%> (ø%)
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.60% <0.00%> (-0.32%) 3.00% <0.00%> (ø%)
...main/java/org/apache/rocketmq/store/CommitLog.java 67.39% <0.00%> (-0.11%) 80.00% <0.00%> (ø%)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 58.13% <0.00%> (+0.46%) 32.00% <0.00%> (+1.00%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be7033...7b76d71. Read the comment docs.

add adminProcess unit test
add adminProcessor unit test kvTable import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants