Skip to content

Conversation

@Git-Yang
Copy link
Member

@Git-Yang Git-Yang commented Nov 9, 2020

What is the purpose of the change

issue #2328

Brief changelog

1.check topicPerms and groupPerms, When updating ACL configuration file.
2.add unit test.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
@coveralls
Copy link

coveralls commented Nov 9, 2020

Coverage Status

Coverage increased (+0.2%) to 54.075% when pulling 7848895 on Git-Yang:enhanced_acl into 88add9d on apache:develop.

@ShannonDing ShannonDing linked an issue May 21, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #2418 (7848895) into develop (88add9d) will increase coverage by 0.08%.
The diff coverage is 92.30%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2418      +/-   ##
=============================================
+ Coverage      47.65%   47.73%   +0.08%     
- Complexity      4512     4528      +16     
=============================================
  Files            552      552              
  Lines          36509    36521      +12     
  Branches        4830     4833       +3     
=============================================
+ Hits           17399    17434      +35     
+ Misses         16880    16864      -16     
+ Partials        2230     2223       -7     
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/rocketmq/acl/common/AclConstants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...che/rocketmq/acl/plain/PlainPermissionManager.java 70.50% <66.66%> (+0.27%) 39.00 <0.00> (ø)
...ava/org/apache/rocketmq/acl/common/Permission.java 92.68% <100.00%> (+2.36%) 26.00 <7.00> (+7.00)
...pache/rocketmq/test/listener/AbstractListener.java 66.66% <0.00%> (-7.41%) 9.00% <0.00%> (-1.00%)
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-4.48%) 17.00% <0.00%> (-1.00%)
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.15%) 3.00% <0.00%> (ø%)
.../main/java/org/apache/rocketmq/common/UtilAll.java 37.98% <0.00%> (+0.32%) 43.00% <0.00%> (ø%)
...ain/java/org/apache/rocketmq/store/MappedFile.java 50.54% <0.00%> (+0.36%) 51.00% <0.00%> (+1.00%)
...rocketmq/common/message/MessageClientIDSetter.java 51.21% <0.00%> (+1.21%) 7.00% <0.00%> (ø%)
...a/org/apache/rocketmq/store/StoreStatsService.java 30.16% <0.00%> (+1.31%) 27.00% <0.00%> (+2.00%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88add9d...7848895. Read the comment docs.

@maixiaohai maixiaohai added the progress/wip Work in progress. Accept or refused to be continue. label May 21, 2021
@duhenglucky duhenglucky merged commit 59718fd into apache:develop May 23, 2021
@zongtanghu zongtanghu modified the milestones: 4.9.1, 4.9.0 Jun 4, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

progress/wip Work in progress. Accept or refused to be continue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The broker instance failed to start due to ACL parameter error

6 participants