Skip to content

Conversation

@Popo-lth
Copy link

What is the purpose of the change

issue #2447

Brief changelog

Modify consumeMessage return null... log output

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 51.579% when pulling 16490b8 on Popo-lth:issues/2447 into c286600 on apache:develop.

@codecov-io
Copy link

Codecov Report

Merging #2448 (16490b8) into develop (c286600) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2448      +/-   ##
=============================================
+ Coverage      45.75%   45.79%   +0.03%     
- Complexity      4298     4302       +4     
=============================================
  Files            547      547              
  Lines          36009    36009              
  Branches        4772     4772              
=============================================
+ Hits           16477    16491      +14     
+ Misses         17471    17463       -8     
+ Partials        2061     2055       -6     
Impacted Files Coverage Δ Complexity Δ
...pl/consumer/ConsumeMessageConcurrentlyService.java 43.68% <100.00%> (ø) 10.00 <0.00> (ø)
...ain/java/org/apache/rocketmq/test/util/MQWait.java 48.64% <0.00%> (-5.41%) 3.00% <0.00%> (-1.00%)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.98% <0.00%> (-3.62%) 16.00% <0.00%> (ø%)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 58.60% <0.00%> (-1.40%) 31.00% <0.00%> (-1.00%)
.../rocketmq/client/impl/consumer/PullAPIWrapper.java 50.42% <0.00%> (-0.86%) 12.00% <0.00%> (-1.00%)
...a/org/apache/rocketmq/store/StoreStatsService.java 28.85% <0.00%> (-0.66%) 25.00% <0.00%> (-1.00%)
...ain/java/org/apache/rocketmq/store/MappedFile.java 50.18% <0.00%> (-0.37%) 50.00% <0.00%> (-1.00%)
...org/apache/rocketmq/store/DefaultMessageStore.java 55.39% <0.00%> (-0.30%) 106.00% <0.00%> (-1.00%)
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø) 30.00% <0.00%> (ø%)
...n/java/org/apache/rocketmq/store/ha/HAService.java 67.88% <0.00%> (+0.33%) 18.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c286600...16490b8. Read the comment docs.

@github-actions
Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jul 24, 2023
@github-actions
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants