Skip to content

Conversation

@xxd763795151
Copy link

Make sure set the target branch to develop

What is the purpose of the change

The original log does not log any error info when sending meessage trace data failed. It`s hard to find the cause of failed on th production environment. And if any people who do not know source code, they even do not know it has sent failed according to log.

Brief changelog

Modify log level from info to warn, And printing exception info.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 51.849% when pulling a400da4 on xxd763795151:trace_data_log into 0239421 on apache:develop.

@codecov-io
Copy link

Codecov Report

Merging #2544 (a400da4) into develop (0239421) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2544      +/-   ##
=============================================
+ Coverage      45.97%   45.98%   +0.01%     
- Complexity      4318     4322       +4     
=============================================
  Files            547      547              
  Lines          36236    36236              
  Branches        4808     4808              
=============================================
+ Hits           16658    16663       +5     
- Misses         17491    17492       +1     
+ Partials        2087     2081       -6     
Impacted Files Coverage Δ Complexity Δ
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 73.60% <33.33%> (-0.51%) 17.00 <0.00> (ø)
...tmq/logappender/log4j2/RocketmqLog4j2Appender.java 36.66% <0.00%> (-8.34%) 4.00% <0.00%> (ø%)
...ain/java/org/apache/rocketmq/test/util/MQWait.java 43.24% <0.00%> (-5.41%) 3.00% <0.00%> (ø%)
...he/rocketmq/client/impl/consumer/ProcessQueue.java 57.67% <0.00%> (-4.19%) 31.00% <0.00%> (-1.00%)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.98% <0.00%> (-3.62%) 16.00% <0.00%> (ø%)
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) 29.00% <0.00%> (-1.00%)
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 59.18% <0.00%> (-1.03%) 11.00% <0.00%> (-1.00%)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (ø) 9.00% <0.00%> (ø%)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0239421...a400da4. Read the comment docs.

@xxd763795151
Copy link
Author

This is an outdated pr, may be has been fixed or fix it later, so I close it now.
I`m sorry for rembering to deal with it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants