Skip to content

Conversation

@SenZhangAI
Copy link

@SenZhangAI SenZhangAI commented Jan 7, 2021

Make sure set the target branch to develop

What is the purpose of the change

fix typo in an example

Brief changelog

  1. fix typo in order message example.

Verifying this change

The example codes of the Order Message has a typo, the producer's topic can not match the consumer's topic.
I found that docs in the Develop branch have already fixed this typo

https://github.com/apache/rocketmq/blame/master/docs/en/Example_Orderly.md#L43

and this has not been fixed on the current official website, see http://rocketmq.apache.org/docs/order-example/

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 51.813% when pulling e61af0e on SenZhangAI:develop into 98aca7f on apache:develop.

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #2569 (e61af0e) into develop (98aca7f) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2569      +/-   ##
=============================================
- Coverage      46.28%   46.19%   -0.10%     
+ Complexity      4349     4343       -6     
=============================================
  Files            547      547              
  Lines          36247    36247              
  Branches        4808     4808              
=============================================
- Hits           16777    16744      -33     
- Misses         17391    17419      +28     
- Partials        2079     2084       +5     
Impacted Files Coverage Δ Complexity Δ
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) 5.00% <0.00%> (-2.00%)
...org/apache/rocketmq/common/stats/StatsItemSet.java 44.77% <0.00%> (-7.47%) 17.00% <0.00%> (-3.00%)
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) 5.00% <0.00%> (-2.00%)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (-4.45%) 9.00% <0.00%> (-1.00%)
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) 28.00% <0.00%> (-1.00%)
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) 13.00% <0.00%> (-1.00%)
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.84% <0.00%> (-3.39%) 11.00% <0.00%> (ø%)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) 14.00% <0.00%> (-1.00%)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 42.59% <0.00%> (-2.89%) 16.00% <0.00%> (-3.00%)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 51.79% <0.00%> (-2.79%) 35.00% <0.00%> (ø%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aca7f...e61af0e. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.19%. Comparing base (98aca7f) to head (e61af0e).
⚠️ Report is 7432 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2569      +/-   ##
=============================================
- Coverage      46.34%   46.19%   -0.15%     
+ Complexity      4356     4343      -13     
=============================================
  Files            547      547              
  Lines          36247    36247              
  Branches        4808     4808              
=============================================
- Hits           16797    16744      -53     
- Misses         17378    17419      +41     
- Partials        2072     2084      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants