Skip to content

Conversation

@horizonzy
Copy link
Member

What is the purpose of the change

For-#2570.
Modify the truncateDirtyLogicFiles judgement, just execute it when maxPhyOffsetOfConsumeQueue > processOffset.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 51.966% when pulling ef19f56 on horizonzy:fix-2570 into 98aca7f on apache:develop.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #2572 (ef19f56) into develop (98aca7f) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2572      +/-   ##
=============================================
- Coverage      46.28%   46.15%   -0.13%     
+ Complexity      4349     4340       -9     
=============================================
  Files            547      547              
  Lines          36247    36247              
  Branches        4808     4808              
=============================================
- Hits           16777    16731      -46     
- Misses         17391    17431      +40     
- Partials        2079     2085       +6     
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/rocketmq/store/CommitLog.java 66.52% <100.00%> (ø) 80.00 <0.00> (+1.00)
.../broker/subscription/SubscriptionGroupManager.java 54.11% <0.00%> (-16.48%) 8.00% <0.00%> (-3.00%)
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-8.96%) 17.00% <0.00%> (-3.00%)
...pache/rocketmq/test/listener/AbstractListener.java 66.66% <0.00%> (-7.41%) 9.00% <0.00%> (-1.00%)
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) 6.00% <0.00%> (-1.00%)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) 7.00% <0.00%> (-1.00%)
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (-4.45%) 9.00% <0.00%> (-1.00%)
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) 28.00% <0.00%> (-1.00%)
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.84% <0.00%> (-3.39%) 11.00% <0.00%> (ø%)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) 14.00% <0.00%> (-1.00%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aca7f...ef19f56. Read the comment docs.

@github-actions
Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jul 21, 2023
@github-actions
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants