[ISSUE #2571] Fix consumeQueue's maxPhysicOffset may greater than commitLog's phyOffset problem.

[horizonzy]

What is the purpose of the change

For-#2571.

Fix consumeQueue's maxPhysicOffset may greater than commitLog's phyOffset problem.

[coveralls]

Coverage increased (+0.1%) to 52.035% when pulling bfecd74 on horizonzy:fix-2571 into 98aca7f on apache:develop.

[codecov-io]

Codecov Report

Merging #2573 (bfecd74) into develop (98aca7f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2573      +/-   ##
=============================================
- Coverage      46.28%   46.24%   -0.05%     
+ Complexity      4349     4344       -5     
=============================================
  Files            547      547              
  Lines          36247    36247              
  Branches        4808     4808              
=============================================
- Hits           16777    16761      -16     
- Misses         17391    17398       +7     
- Partials        2079     2088       +9     

Impacted Files	Coverage Δ	Complexity Δ
...n/java/org/apache/rocketmq/store/ConsumeQueue.java	64.24% <100.00%> (ø)	56.00 <0.00> (ø)
.../broker/subscription/SubscriptionGroupManager.java	54.11% <0.00%> (-16.48%)	8.00% <0.00%> (-3.00%)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java	75.00% <0.00%> (-7.70%)	10.00% <0.00%> (-1.00%)
...ketmq/common/protocol/body/ConsumerConnection.java	95.83% <0.00%> (-4.17%)	13.00% <0.00%> (-1.00%)
...mq/client/impl/consumer/RebalanceLitePullImpl.java	50.84% <0.00%> (-3.39%)	11.00% <0.00%> (ø%)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java	46.26% <0.00%> (-2.99%)	14.00% <0.00%> (-1.00%)
...nt/impl/consumer/ConsumeMessageOrderlyService.java	42.59% <0.00%> (-2.89%)	16.00% <0.00%> (-3.00%)
...client/consumer/store/RemoteBrokerOffsetStore.java	67.56% <0.00%> (-1.81%)	20.00% <0.00%> (-2.00%)
.../rocketmq/broker/filter/ConsumerFilterManager.java	72.19% <0.00%> (-1.80%)	33.00% <0.00%> (ø%)
...etmq/client/latency/LatencyFaultToleranceImpl.java	50.00% <0.00%> (-1.29%)	8.00% <0.00%> (ø%)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aca7f...bfecd74. Read the comment docs.

[RongtongJin]

I think this is indeed better, what do you think? @zongtanghu @duhenglucky

[github-actions]

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

[github-actions]

This PR was closed because it has been inactive for 3 days since being marked as stale.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.24%. Comparing base (98aca7f) to head (bfecd74).
⚠️ Report is 7427 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2573      +/-   ##
=============================================
- Coverage      46.34%   46.24%   -0.10%     
+ Complexity      4356     4344      -12     
=============================================
  Files            547      547              
  Lines          36247    36247              
  Branches        4808     4808              
=============================================
- Hits           16797    16761      -36     
- Misses         17378    17398      +20     
- Partials        2072     2088      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.