[ISSUE #2710] Delete unused parameters #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
changed the title
Contributor
|
Plz create an issue before you submit a pull request. |
sunxi92
changed the title
Contributor
Author
done |
RongtongJin
approved these changes
Mar 8, 2021
cserwen
pushed a commit
to cserwen/rocketmq
that referenced
this pull request
Apr 2, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildSubscriptionData function in FilterAPI. java is used to build the SubscriptionData object, and the parameter of this function contains the ConsumerGroup, Topic and Substring. But the SubscriptionData does not have the ConsumerGroup property, and this parameter is not used in this function, so I deleted this parameter and changed the place where the buildSubscriptionData function is called
#2710