Skip to content

Conversation

@wathenjiang
Copy link

Make sure set the target branch to develop

What is the purpose of the change

Idle event should not continue to spread in pipeline any more ,because NO Handler will deal with this event any more.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 51.846% when pulling f949709 on Spongecaptain:jwjFork into 9eae1d6 on apache:develop.

@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #2699 (f949709) into develop (39bb938) will decrease coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2699      +/-   ##
=============================================
- Coverage      46.13%   45.55%   -0.58%     
+ Complexity      4337     3856     -481     
=============================================
  Files            547      473      -74     
  Lines          36236    32746    -3490     
  Branches        4808     4383     -425     
=============================================
- Hits           16719    14919    -1800     
+ Misses         17443    15914    -1529     
+ Partials        2074     1913     -161     
Impacted Files Coverage Δ Complexity Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-8.96%) 17.00% <0.00%> (-3.00%)
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-4.45%) 8.00% <0.00%> (-1.00%)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 51.79% <0.00%> (-3.59%) 35.00% <0.00%> (-1.00%)
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.84% <0.00%> (-3.39%) 11.00% <0.00%> (ø%)
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 82.69% <0.00%> (-1.93%) 11.00% <0.00%> (-1.00%)
...client/consumer/store/RemoteBrokerOffsetStore.java 67.56% <0.00%> (-1.81%) 20.00% <0.00%> (-2.00%)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) 8.00% <0.00%> (ø%)
...org/apache/rocketmq/store/DefaultMessageStore.java 56.45% <0.00%> (-0.13%) 110.00% <0.00%> (+1.00%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 66.42% <0.00%> (-0.11%) 79.00% <0.00%> (ø%)
...ketmq/test/util/parallel/ParallelTaskExecutor.java
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39bb938...f949709. Read the comment docs.

@vongosling vongosling closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants