Skip to content

[ISSUE #2729] Replace with Math.min method call#2798

Merged
RongtongJin merged 1 commit into
apache:developfrom
drgnchan:develop
Apr 12, 2021
Merged

[ISSUE #2729] Replace with Math.min method call#2798
RongtongJin merged 1 commit into
apache:developfrom
drgnchan:develop

Conversation

@drgnchan
Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

polish

Brief changelog

replace with Math.min method call

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@drgnchan
Copy link
Copy Markdown
Contributor Author

#2797

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 51.822% when pulling 39509c5 on drgnchan:develop into 7680063 on apache:develop.

@RongtongJin RongtongJin changed the title polish: replace with Math.min method call [ISSUE #2729] Replace with Math.min method call Apr 12, 2021
@RongtongJin RongtongJin merged commit af8a964 into apache:develop Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants