Skip to content

Conversation

@areyouok
Copy link
Contributor

  1. Change log level to debug: "Half offset {} has been committed/rolled back"
  2. Optimise lock in WaitNotifyObject
  3. Remove lock in HAService
  4. Remove lock in GroupCommitService
  5. Eliminate array copy in HA
  6. Remove putMessage/putMessages method in CommitLog which has too many duplicated code.
  7. Change default value of some parameters: sendMessageThreadPoolNums/useReentrantLockWhenPutMessage/flushCommitLogTimed/endTransactionThreadPoolNums
  8. Optimise performance of asyncPutMessage (extract some code out of putMessage lock)
  9. extract generation of msgId out of lock in CommitLog (now only for single message processor)
  10. extract generation of topicQueueTable key out of sync code
  11. extract generation of msgId out of lock in CommitLog (for batch)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 52.362% when pulling 541c35d on areyouok:dev_speed_A into fe78d18 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (fe78d18) to head (541c35d).
Report is 7113 commits behind head on develop.

Files with missing lines Patch % Lines
...saction/queue/TransactionalMessageServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2884      +/-   ##
=============================================
+ Coverage      46.49%   46.61%   +0.11%     
- Complexity      4407     4419      +12     
=============================================
  Files            552      552              
  Lines          36500    36500              
  Branches        4828     4828              
=============================================
+ Hits           16972    17015      +43     
+ Misses         17405    17356      -49     
- Partials        2123     2129       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francisoliverlee francisoliverlee merged commit be6eaf8 into apache:develop May 14, 2021
@francisoliverlee francisoliverlee linked an issue May 17, 2021 that may be closed by this pull request
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
[ISSUE apache#2883] [Part A] Improve produce performance in M/S mode.
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
[ISSUE apache#2883] [Part A] Improve produce performance in M/S mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve produce performance in M/S mode

4 participants