Skip to content

[ISSUE #3097] docs remove obsolete/error configuration#3116

Merged
duhenglucky merged 1 commit into
apache:developfrom
trdmm:develop
Jul 14, 2021
Merged

[ISSUE #3097] docs remove obsolete/error configuration#3116
duhenglucky merged 1 commit into
apache:developfrom
trdmm:develop

Conversation

@trdmm
Copy link
Copy Markdown
Contributor

@trdmm trdmm commented Jul 1, 2021

Make sure set the target branch to develop

What is the purpose of the change

Update the docs

Brief changelog

docs remove obsolete/error configuration

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 53.885% when pulling 94e0899 on trdmm:develop into 9a5ec90 on apache:develop.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3116 (94e0899) into develop (df35edf) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3116      +/-   ##
=============================================
- Coverage      47.98%   47.84%   -0.15%     
+ Complexity      4561     4552       -9     
=============================================
  Files            552      552              
  Lines          36633    36637       +4     
  Branches        4845     4845              
=============================================
- Hits           17578    17528      -50     
- Misses         16827    16879      +52     
- Partials        2228     2230       +2     
Impacted Files Coverage Δ
.../broker/subscription/SubscriptionGroupManager.java 54.11% <0.00%> (-16.48%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-8.96%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 71.15% <0.00%> (-7.70%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.00%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-0.96%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.47% <0.00%> (-0.66%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df35edf...94e0899. Read the comment docs.

@duhenglucky duhenglucky merged commit 2bd0676 into apache:develop Jul 14, 2021
@duhenglucky
Copy link
Copy Markdown
Contributor

fix 3097

@zongtanghu zongtanghu added this to the 4.9.1 milestone Jul 28, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
[ISSUE apache#3097] docs remove obsolete/error configuration
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
[ISSUE apache#3097] docs remove obsolete/error configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants