Skip to content

Conversation

@hjm2015
Copy link

@hjm2015 hjm2015 commented Aug 29, 2021

去除多余配置,SocketChannel 创建出来默认就是阻塞的,并且后面又再次设置非阻塞的,所以这个设置阻塞是没有必要的

去除多余配置,SocketChannel 创建出来默认就是阻塞的,并且后面又再次设置非阻塞的,所以这个设置阻塞是没有必要的
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 54.227% when pulling f225c01 on hjm2015:Removing-redundant-configuration into 2cac866 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3300 (f225c01) into develop (a7e71cb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3300      +/-   ##
=============================================
- Coverage      47.98%   47.97%   -0.01%     
+ Complexity      4560     4554       -6     
=============================================
  Files            552      552              
  Lines          36521    36537      +16     
  Branches        4818     4822       +4     
=============================================
+ Hits           17523    17529       +6     
- Misses         16782    16785       +3     
- Partials        2216     2223       +7     
Impacted Files Coverage Δ
.../apache/rocketmq/remoting/common/RemotingUtil.java 12.74% <ø> (+0.12%) ⬆️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...sumer/rebalance/AllocateMessageQueueAveragely.java 56.52% <0.00%> (-4.35%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 49.55% <0.00%> (-1.49%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 29.50% <0.00%> (-1.32%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 39.45% <0.00%> (-0.79%) ⬇️
...va/org/apache/rocketmq/common/message/Message.java 54.21% <0.00%> (ø)
...g/apache/rocketmq/filter/parser/TokenMgrError.java 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e71cb...f225c01. Read the comment docs.

@github-actions
Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jul 19, 2023
@github-actions
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants