Skip to content

Fix checkstyle problem#3396

Closed
lifepuzzlefun wants to merge 2 commits into
apache:developfrom
lifepuzzlefun:code_format_acl_util
Closed

Fix checkstyle problem#3396
lifepuzzlefun wants to merge 2 commits into
apache:developfrom
lifepuzzlefun:code_format_acl_util

Conversation

@lifepuzzlefun
Copy link
Copy Markdown
Contributor

@lifepuzzlefun lifepuzzlefun commented Oct 3, 2021

What is the purpose of the change

maven build checkstyle fail on current develop branch.

Brief changelog

just some code reformat, no logic change.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lifepuzzlefun lifepuzzlefun changed the title 1. fix checkstyle problem Fix checkstyle problem Oct 3, 2021
@lifepuzzlefun lifepuzzlefun deleted the code_format_acl_util branch October 3, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant