Skip to content

Conversation

@cserwen
Copy link
Member

@cserwen cserwen commented Nov 18, 2021

Make sure set the target branch to develop

What is the purpose of the change

#3498

Brief changelog

Use polling to calculate queueId

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Nov 18, 2021

Coverage Status

Coverage decreased (-0.03%) to 53.451% when pulling ad72617 on cserwen:5.0.0-alpha into 4506f34 on apache:5.0.0-alpha.

@cserwen cserwen changed the title [ISSUE #3498]Make messages in reviveTopic more evenly written to different queues [ISSUE #3498] Make messages in reviveTopic more evenly written to different queues Nov 18, 2021
@Git-Yang
Copy link
Member

Git-Yang commented Jan 5, 2022

rocketmq-common: Too many files with unapproved license
Can you deal with it ?

@cserwen
Copy link
Member Author

cserwen commented Jan 5, 2022

rocketmq-common: Too many files with unapproved license Can you deal with it ?

@Git-Yang Ok, I will fix it in another pr firstly.

@cserwen
Copy link
Member Author

cserwen commented Jan 10, 2022

@Git-Yang @duhenglucky @odbozhou Can you help me to merge this pr? There seems to be no problem.

@odbozhou odbozhou merged commit 03526d8 into apache:5.0.0-alpha Jan 12, 2022
RongtongJin pushed a commit that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants