Skip to content

Fix pullconsumer notes#3542

Closed
mrhbj wants to merge 2 commits intoapache:masterfrom
mrhbj:fix-pullconsumer-notes
Closed

Fix pullconsumer notes#3542
mrhbj wants to merge 2 commits intoapache:masterfrom
mrhbj:fix-pullconsumer-notes

Conversation

@mrhbj
Copy link
Contributor

@mrhbj mrhbj commented Nov 29, 2021

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Git-Yang
Copy link
Member

Can you create an ISSUE for this PR?

@mrhbj
Copy link
Contributor Author

mrhbj commented Nov 29, 2021

Can you create an ISSUE for this PR?

ok

@mrhbj mrhbj closed this Nov 29, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 54.401% when pulling d941051 on mrhbj:fix-pullconsumer-notes into a75c742 on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants