Skip to content

Conversation

@duhengforever
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

When sending a transaction check request, ProducerManager returned available connection is not the current connection, but the next connection.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhengforever duhengforever changed the title [ISSUE #367]Fix the get connection bug when sending transactional message [ISSUE #367]Fix the get connection bug when sending transactional check message Jul 16, 2018
@duhengforever duhengforever changed the title [ISSUE #367]Fix the get connection bug when sending transactional check message [ISSUE #367]Fix the get connection bug when sending transactional check request Jul 16, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 42.201% when pulling 5fc2032 on duhengforever:develop_fix into d8c446e on apache:develop.

Copy link
Member

@vongosling vongosling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vongosling vongosling merged commit ed433a3 into apache:develop Jul 17, 2018
@vongosling vongosling added this to the 4.3.0 milestone Jul 17, 2018
@duhengforever duhengforever deleted the develop_fix branch July 31, 2018 03:12
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants