Skip to content

Conversation

@hzdavid
Copy link

@hzdavid hzdavid commented Jul 18, 2018

What is the purpose of the change

fix wrong word

Brief changelog

fix wrong word eclipse to elapsed
the word is at org.apache.rocketmq.common.ServiceThread.java

Verifying this change

use elapsed instead

zhouxinyu and others added 28 commits December 18, 2017 13:55
…")" (#269)

Minor fix for command tool, remove duplicates initCommand and missing tag ")"
This reverts commit bc84984.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 39.983% when pulling 3bf25f2 on hzdavid:master into 0f76489 on apache:master.

…isDebugEnabled is helpful to reduce log printing cpu cost.
@duhengforever
Copy link
Contributor

Thanks for participating,please open an issue first,then make this PR associate it , and pull request to develop branch will be a better choice.

…ng HashMap instead can be helpful for the performance.
@hzdavid hzdavid changed the base branch from master to develop July 19, 2018 03:56
@vongosling
Copy link
Member

@hzdavid thanks for your pr, Could you rebase your commits, I have seen so many other branch merged info. It would be helpful if you redo the pr.

@vongosling vongosling closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants