Skip to content

Conversation

@loongs-zhang
Copy link
Member

@loongs-zhang loongs-zhang commented Dec 31, 2021

What is the purpose of the change

support async ordered producer

Brief changelog

It supports sending ordered messages asynchronously, providing a good foundation for automatic batch aggregation.

Verifying this change

design here
async ordered producer

see org.apache.rocketmq.client.producer.DefaultMQProducerTest#testSendMessageAsync

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Dec 31, 2021

Coverage Status

Coverage decreased (-0.08%) to 53.288% when pulling a29ac44 on dragon-zhang:dev_async_orderly_producer2 into 9f9b109 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #3691 (a29ac44) into develop (75557b8) will decrease coverage by 2.35%.
The diff coverage is 48.99%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3691      +/-   ##
=============================================
- Coverage      49.66%   47.30%   -2.36%     
- Complexity      4722     5065     +343     
=============================================
  Files            555      632      +77     
  Lines          36837    41485    +4648     
  Branches        4856     5399     +543     
=============================================
+ Hits           18294    19624    +1330     
- Misses         16239    19423    +3184     
- Partials        2304     2438     +134     
Impacted Files Coverage Δ
.../rocketmq/client/producer/ProcessableCallback.java 0.00% <0.00%> (ø)
...etmq/common/concurrent/OrderedExecutorService.java 0.00% <0.00%> (ø)
...etmq/common/concurrent/DefaultOrderedExecutor.java 34.61% <34.61%> (ø)
...mmon/concurrent/DefaultOrderedExecutorService.java 40.00% <40.00%> (ø)
...pache/rocketmq/common/utils/BitOperationUtils.java 53.65% <53.65%> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.32% <65.78%> (+0.37%) ⬆️
...he/rocketmq/client/producer/DefaultMQProducer.java 57.99% <75.00%> (+0.64%) ⬆️
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-1.50%) ⬇️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75557b8...a29ac44. Read the comment docs.

@loongs-zhang loongs-zhang changed the title [RIP22][RIP26] support async ordered producer [RIP-22] [RIP-26] support async ordered producer Jan 1, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants