Skip to content

[ISSUE #3434] Consumers start slowly #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Cczzzz wants to merge 1 commit into from
Closed

[ISSUE #3434] Consumers start slowly #3759

Cczzzz wants to merge 1 commit into from

Conversation

@Cczzzz
Copy link
Contributor

@Cczzzz Cczzzz commented Jan 14, 2022

No description provided.

@Cczzzz
Copy link
Contributor Author

Cczzzz commented Jan 14, 2022

fix #3434 and #2738

@Cczzzz Cczzzz changed the title fix #3434 and #2738 [ISSUE #3434] Consumers start slowly Jan 14, 2022
@coveralls
Copy link

coveralls commented Jan 14, 2022

Coverage Status

Coverage increased (+0.1%) to 54.498% when pulling e2868b1 on Cczzzz:master into 1b420ce on apache:master.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #3759 (e2868b1) into master (1b420ce) will increase coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3759      +/-   ##
============================================
+ Coverage     48.15%   48.21%   +0.06%     
- Complexity     4593     4605      +12     
============================================
  Files           555      556       +1     
  Lines         36755    36778      +23     
  Branches       4841     4844       +3     
============================================
+ Hits          17698    17733      +35     
+ Misses        16826    16811      -15     
- Partials       2231     2234       +3
Impacted Files Coverage Δ
...rocketmq/client/impl/factory/MQClientInstance.java 51.47% <75.00%> (+1.84%) ⬆️
...ocketmq/client/impl/consumer/HeartbeatService.java 81.81% <81.81%> (ø)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.49%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 73.83% <0.00%> (-0.12%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.47% <0.00%> (+0.24%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.31%) ⬆️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 40.23% <0.00%> (+0.39%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.39% <0.00%> (+0.46%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b420ce...e2868b1. Read the comment docs.

@Cczzzz Cczzzz changed the base branch from master to develop January 25, 2022 13:19
This was linked to issues Feb 14, 2022
BUG ： Consumers start slowly #3434
Closed
sendHeartbeatToAllBroker may execute before pull request after rebalance #2738
Closed
@Cczzzz
Copy link
Contributor Author

Cczzzz commented Feb 24, 2022

A cached queue of length 1 to ensure that the last task will be executed

RongtongJin
RongtongJin reviewed Feb 25, 2022
View reviewed changes
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
Comment on lines +246 to +247
//Start heartbeat service
this.heartbeatService.start();
Copy link
Contributor

@RongtongJin RongtongJin Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no shutdown heartbeatService when MQClientInstance shutdown

client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
Comment on lines +246 to +247
//Start heartbeat service
this.heartbeatService.start();
Copy link
Contributor

@RongtongJin RongtongJin Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no shutdown heartbeatService thread when the MQClientInstance shutdown

Copy link
Contributor Author

@Cczzzz Cczzzz Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no shutdown heartbeatService thread when the MQClientInstance shutdown

i will fix it

@RongtongJin
Copy link
Contributor

RongtongJin commented Feb 25, 2022

It seems that there are some unnecessary commits in this pr.

@Cczzzz Cczzzz changed the base branch from develop to master March 3, 2022 06:50
@Cczzzz Cczzzz closed this Mar 3, 2022
@Cczzzz
Copy link
Contributor Author

Cczzzz commented Mar 3, 2022

It seems that there are some unnecessary commits in this pr.

that is because i checkout -b from master

@Cczzzz
Copy link
Contributor Author

Cczzzz commented Mar 11, 2022

why it closed @RongtongJin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RongtongJin RongtongJin RongtongJin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG ： Consumers start slowly sendHeartbeatToAllBroker may execute before pull request after rebalance

4 participants

@Cczzzz @coveralls @codecov-commenter @RongtongJin