Skip to content

[ISSUE #3818] update guava to 31.0.1-jre#3821

Merged
duhenglucky merged 1 commit intoapache:developfrom
pjfanning:patch-2
Feb 7, 2022
Merged

[ISSUE #3818] update guava to 31.0.1-jre#3821
duhenglucky merged 1 commit intoapache:developfrom
pjfanning:patch-2

Conversation

@pjfanning
Copy link
Member

#3818

Make sure set the target branch to develop

What is the purpose of the change

guava 19.0 has a CVE

Brief changelog

pom change

Verifying this change

CI build

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@pjfanning pjfanning changed the title guava 31.0.1-jre [Issue-3818] guava 31.0.1-jre Feb 5, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 51.194% when pulling 18afb87 on pjfanning:patch-2 into 32dd2d8 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.14%. Comparing base (32dd2d8) to head (18afb87).
⚠️ Report is 7003 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3821      +/-   ##
=============================================
- Coverage      47.16%   47.14%   -0.03%     
+ Complexity      4885     4884       -1     
=============================================
  Files            636      636              
  Lines          42468    42468              
  Branches        5553     5553              
=============================================
- Hits           20031    20021      -10     
- Misses         19927    19946      +19     
+ Partials        2510     2501       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duhenglucky duhenglucky merged commit dbbc88a into apache:develop Feb 7, 2022
@duhenglucky duhenglucky added this to the 4.9.3 milestone Feb 7, 2022
@pjfanning pjfanning deleted the patch-2 branch February 7, 2022 01:59
@francisoliverlee francisoliverlee changed the title [Issue-3818] guava 31.0.1-jre [ISSUE #3818] guava 31.0.1-jre Feb 21, 2022
@francisoliverlee francisoliverlee changed the title [ISSUE #3818] guava 31.0.1-jre [Issue-3818] update guava to 31.0.1-jre Feb 21, 2022
@francisoliverlee francisoliverlee changed the title [Issue-3818] update guava to 31.0.1-jre [ISSUE #3818] update guava to 31.0.1-jre Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants