[ISSUE #3968]RemotingCommand decodeCommandCustomHeader optimized.
#3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2022 19:07
1. avoid java reflection `setAccessible` each time 2. direct compare field Class without `getCanonicalName`.
lifepuzzlefun
changed the title
decodeCommandCustomHeader optimized.decodeCommandCustomHeader optimized.
added 3 commits
March 12, 2022 19:40
…nto optimize_remoting_command_decode
Codecov Report
@@ Coverage Diff @@
## develop #3965 +/- ##
=============================================
+ Coverage 47.68% 47.88% +0.20%
- Complexity 4972 5000 +28
=============================================
Files 633 633
Lines 42579 42510 -69
Branches 5589 5574 -15
=============================================
+ Hits 20305 20358 +53
+ Misses 19764 19651 -113
+ Partials 2510 2501 -9
Continue to review full report at Codecov.
|
areyouok
reviewed
Mar 14, 2022
|
|
||
| public static RemotingCommand createResponseCommand(int code, String remark, | ||
| Class<? extends CommandCustomHeader> classHeader) { | ||
| Class<? extends CommandCustomHeader> classHeader) { |
Contributor
There was a problem hiding this comment.
please revert irrelevant modifications.
|
|
||
| public CommandCustomHeader decodeCommandCustomHeader( | ||
| Class<? extends CommandCustomHeader> classHeader) throws RemotingCommandException { | ||
| Class<? extends CommandCustomHeader> classHeader) throws RemotingCommandException { |
Contributor
There was a problem hiding this comment.
please revert irrelevant modifications.
| } catch (InstantiationException e) { | ||
| return null; | ||
| } catch (IllegalAccessException e) { | ||
| } catch (InstantiationException | IllegalAccessException e) { |
Contributor
There was a problem hiding this comment.
since 4.9.3 we should keep compatible under java 1.6, so you should revert this change.
| if (fields == null) { | ||
| fields = classHeader.getDeclaredFields(); | ||
|
|
||
| fields = Arrays.stream(fields) |
Contributor
Author
There was a problem hiding this comment.
fixed. and this remind me to avoid create new Field[] here which improve the performance! thank you~
| return "RemotingCommand [code=" + code + ", language=" + language + ", version=" + version + ", opaque=" + opaque + ", flag(B)=" | ||
| + Integer.toBinaryString(flag) + ", remark=" + remark + ", extFields=" + extFields + ", serializeTypeCurrentRPC=" | ||
| + serializeTypeCurrentRPC + "]"; | ||
| + Integer.toBinaryString(flag) + ", remark=" + remark + ", extFields=" + extFields + ", serializeTypeCurrentRPC=" |
Contributor
There was a problem hiding this comment.
please revert irrelevant modifications.
added 3 commits
March 15, 2022 12:42
areyouok
approved these changes
Mar 17, 2022
Contributor
areyouok
left a comment
areyouok
left a comment
There was a problem hiding this comment.
I approve this PR.
but I don't known if we should add a module. maybe you can run the test locally.
let's listen to other person's opinion
yuz10
approved these changes
Mar 26, 2022
hzh0425
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3968
setAccessibleeach timegetCanonicalName.