Skip to content

[ISSUE #4083] fix for loop, the current loop can not reach the last one in the array#4084

Closed
Hen1ng wants to merge 1 commit intoapache:developfrom
Hen1ng:fix_for_loop
Closed

[ISSUE #4083] fix for loop, the current loop can not reach the last one in the array#4084
Hen1ng wants to merge 1 commit intoapache:developfrom
Hen1ng:fix_for_loop

Conversation

@Hen1ng
Copy link
Contributor

@Hen1ng Hen1ng commented Apr 1, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix for loop, the current loop can not reach the last one in the array
XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
    Fixes #
    Fixes The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array. #4083

@Hen1ng Hen1ng changed the title fix for loop, the current loop can not reach the last one in the array 【#4083】fix for loop, the current loop can not reach the last one in the array Apr 2, 2022
@Hen1ng Hen1ng changed the title 【#4083】fix for loop, the current loop can not reach the last one in the array 【ISSUE #4083】fix for loop, the current loop can not reach the last one in the array Apr 2, 2022
@Hen1ng Hen1ng changed the title 【ISSUE #4083】fix for loop, the current loop can not reach the last one in the array [ISSUE #4083] fix for loop, the current loop can not reach the last one in the array Apr 2, 2022
@Hen1ng Hen1ng closed this Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.

2 participants