Skip to content

[ISSUE #4109] add permission validation on broker side for ordinary topic#4121

Closed
MatrixHB wants to merge 1 commit into
apache:developfrom
MatrixHB:fix_broker_permission
Closed

[ISSUE #4109] add permission validation on broker side for ordinary topic#4121
MatrixHB wants to merge 1 commit into
apache:developfrom
MatrixHB:fix_broker_permission

Conversation

@MatrixHB
Copy link
Copy Markdown
Contributor

@MatrixHB MatrixHB commented Apr 6, 2022

to solve the problem described in ISSUE #4109

This change will cause the broker to throw a "NO_PERMISSION" exception. If the producer uses SYNC mode, it will retry sending to another broker, seeing DefaultMQProducerImpl#sendDefaultImpl, so the SYNC mode will not be affected.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 51.728% when pulling 9e9c160 on MatrixHB:fix_broker_permission into e7c87fa on apache:develop.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 51.728% when pulling 9e9c160 on MatrixHB:fix_broker_permission into e7c87fa on apache:develop.

@dongeforever
Copy link
Copy Markdown
Member

Adding the perm check for ordinary topic, the client will get exceptions and cannot failover during the matadata discovery time, which is up to 30 seconds.

For ordinary topics, the original design expects the client to discover the new topic route and send only to the writable brokers, which introduces no exceptions and makes the wipe-perm process more smoothly.

@MatrixHB
Copy link
Copy Markdown
Contributor Author

MatrixHB commented Apr 6, 2022

Adding the perm check for ordinary topic, the client will get exceptions and cannot failover during the matadata discovery time, which is up to 30 seconds.

For ordinary topics, the original design expects the client to discover the new topic route and send only to the writable brokers, which introduces no exceptions and makes the wipe-perm process more smoothly.

Thanks, this change is not so elegant actually. Maybe updating the client version is enough to solve this problem. Next time we meet this trouble we can discuss this again.

@MatrixHB MatrixHB closed this Apr 6, 2022
@MatrixHB MatrixHB deleted the fix_broker_permission branch April 6, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants