-
Notifications
You must be signed in to change notification settings - Fork 12k
[ISSUE #4591] Add synchronized #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4591] Add synchronized #4592
Conversation
Inuyasha-Monster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the best way , commit message include issue id and pr id
Codecov Report
@@ Coverage Diff @@
## develop #4592 +/- ##
=============================================
+ Coverage 43.09% 43.11% +0.01%
- Complexity 7676 7683 +7
=============================================
Files 994 994
Lines 68942 68942
Branches 9132 9132
=============================================
+ Hits 29712 29725 +13
+ Misses 35497 35485 -12
+ Partials 3733 3732 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for your advice,i will add issue id or pr id when i submit the code |
tsunghanjacktsai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is no concurrency issue for LoggingBuilder#getFile() here since there is no usage found in the code. But I guess we could make it synchronized in advance to prevent problems in the future.
d873adc
6f6b10e to
d873adc
Compare
Make sure set the target branch to
developWhat is the purpose of the change
Close #4591
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.