Skip to content

Conversation

@drpmma
Copy link
Contributor

@drpmma drpmma commented Jul 15, 2022

Make sure set the target branch to develop

What is the purpose of the change

Support bname in request protocol.

Brief changelog

Support bname for request: PULL_MESSAGE, UPDATE_CONSUMER_OFFSET, QUERY_CONSUMER_OFFSET, SEARCH_OFFSET_BY_TIMESTAMP, GET_MIN_OFFSET, GET_MAX_OFFSET.

Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov-commenter
Copy link

Codecov Report

Merging #4615 (d473cb2) into develop (b136f9b) will decrease coverage by 0.03%.
The diff coverage is 36.36%.

@@              Coverage Diff              @@
##             develop    #4615      +/-   ##
=============================================
- Coverage      43.42%   43.38%   -0.04%     
+ Complexity      6203     6196       -7     
=============================================
  Files            817      817              
  Lines          57654    57675      +21     
  Branches        7873     7875       +2     
=============================================
- Hits           25036    25024      -12     
- Misses         29375    29408      +33     
  Partials        3243     3243              
Impacted Files Coverage Δ
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 4.93% <0.00%> (ø)
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 33.33% <ø> (ø)
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 25.88% <0.00%> (-0.07%) ⬇️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 24.51% <40.90%> (-0.08%) ⬇️
...client/consumer/store/RemoteBrokerOffsetStore.java 68.14% <100.00%> (+0.57%) ⬆️
.../rocketmq/client/impl/consumer/PullAPIWrapper.java 40.60% <100.00%> (+0.36%) ⬆️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 33.20% <0.00%> (-2.21%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 45.64% <0.00%> (-1.80%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.47% <0.00%> (-0.71%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b136f9b...d473cb2. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 47.506% when pulling d473cb2 on drpmma:feature/stream-5.0 into 00da3e7 on apache:develop.

requestHeader.setConsumerGroup(this.groupName);
requestHeader.setQueueId(mq.getQueueId());
requestHeader.setCommitOffset(offset);
requestHeader.setBname(mq.getBrokerName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drpmma ,

Why not just simply name it "brokerName" instead of "bname" to make it more straightforward? I felt confused for a second after I saw your description haha.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bname is not in the scope of this pr, see b6ff649 for more information.

I guess bname is shorter than brokerName thus it is more efficient in tranport.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drpmma Oh, okay. That's reasonable.

@zhouxinyu
Copy link
Member

Let's merge this PR first, although there is one ci failed, @RongtongJin is trying to fix this problem in another thread.

@zhouxinyu zhouxinyu merged commit ac6ccc5 into apache:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants