Skip to content

[ISSUE #4650] Admin tool sendMsgStatus add more description#4651

Merged
duhenglucky merged 6 commits intoapache:developfrom
Oliverwqcwrw:develop-sendmsgstatus-fix-32
Jul 26, 2022
Merged

[ISSUE #4650] Admin tool sendMsgStatus add more description#4651
duhenglucky merged 6 commits intoapache:developfrom
Oliverwqcwrw:develop-sendmsgstatus-fix-32

Conversation

@Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4650

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Oliverwqcwrw Oliverwqcwrw force-pushed the develop-sendmsgstatus-fix-32 branch from 6fd47c5 to 5cc2d1f Compare July 21, 2022 10:20
@Oliverwqcwrw Oliverwqcwrw changed the title [ISSUE #4650] Fix admin tool sendMsgStatus [ISSUE #4650] Admin tool sendMsgStatus add more description Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #4651 (dcf3c29) into develop (8ccffa7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4651      +/-   ##
=============================================
+ Coverage      44.31%   44.35%   +0.03%     
- Complexity      7280     7291      +11     
=============================================
  Files            968      968              
  Lines          65899    65899              
  Branches        8635     8635              
=============================================
+ Hits           29204    29227      +23     
+ Misses         33086    33069      -17     
+ Partials        3609     3603       -6     
Impacted Files Coverage Δ
...tmq/tools/command/broker/SendMsgStatusCommand.java 34.28% <100.00%> (ø)
...mq/broker/topic/TopicQueueMappingCleanService.java 12.43% <0.00%> (-3.63%) ⬇️
...org/apache/rocketmq/store/ha/DefaultHAService.java 67.48% <0.00%> (-1.85%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 73.56% <0.00%> (-1.37%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 38.19% <0.00%> (-0.55%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.38% <0.00%> (-0.48%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 53.76% <0.00%> (-0.36%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.24% <0.00%> (-0.24%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 68.84% <0.00%> (+0.09%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 70.32% <0.00%> (+0.16%) ⬆️
... and 14 more

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 48.503% when pulling dcf3c29 on Oliverwqcwrw:develop-sendmsgstatus-fix-32 into 8ccffa7 on apache:develop.

@duhenglucky duhenglucky merged commit 8034690 into apache:develop Jul 26, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The admin tool sendMsgStatus add description with brokerName

6 participants