Skip to content

Conversation

@JanWarlen
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

mqadmin deleteTopic only request master brokers

Brief changelog

org.apache.rocketmq.tools.command.topic.DeleteTopicSubCommand#deleteTopic
-- Set brokerAddressSet = CommandUtil.fetchMasterAndSlaveAddrByClusterName(adminExt, clusterName);
-- adminExt.deleteTopicInBroker(brokerAddressSet, topic);
++ Set masterBrokerAddressSet = CommandUtil.fetchMasterAddrByClusterName(adminExt, clusterName);
++ adminExt.deleteTopicInBroker(masterBrokerAddressSet, topic);

Verifying this change

I cannot exec mvn clean package -DskipTests on branch 4.9.x,so I did same change on branch release-4.9.4(didn't commit).
And tested on my 1m-2s-sync cluster.

[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name         #Topic                                            #Consumer Group                                 
DefaultCluster        SCHEDULE_TOPIC_XXXX                                                                                                               
DefaultCluster        RMQ_SYS_TRANS_HALF_TOPIC                                                                                                          
DefaultCluster        DefaultCluster_REPLY_TOPIC                                                                                                        
DefaultCluster        BenchmarkTest                                                                                                                     
DefaultCluster        OFFSET_MOVED_EVENT                                                                                                                
DefaultCluster        broker-a                                                                                                                          
DefaultCluster        TBW102                                                                                                                            
DefaultCluster        SELF_TEST_TOPIC                                                                                                                   
DefaultCluster        DefaultCluster                                                                                                                    

[root@master bin]# date
Thu Jul 21 07:11:08 EDT 2022
[root@master bin]# ./mqadmin updateTopic -n master:9876 -c DefaultCluster -t test_topic
create topic to 192.168.125.201:10911 success.
TopicConfig [topicName=test_topic, readQueueNums=8, writeQueueNums=8, perm=RW-, topicFilterType=SINGLE_TAG, topicSysFlag=0, order=false]
[root@master bin]# date
Thu Jul 21 07:11:17 EDT 2022
[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name         #Topic                                            #Consumer Group                                 
DefaultCluster        SCHEDULE_TOPIC_XXXX                                                                                                               
DefaultCluster        RMQ_SYS_TRANS_HALF_TOPIC                                                                                                          
DefaultCluster        DefaultCluster_REPLY_TOPIC                                                                                                        
DefaultCluster        test_topic                                                                                                                        
DefaultCluster        BenchmarkTest                                                                                                                     
DefaultCluster        OFFSET_MOVED_EVENT                                                                                                                
DefaultCluster        broker-a                                                                                                                          
DefaultCluster        TBW102                                                                                                                            
DefaultCluster        SELF_TEST_TOPIC                                                                                                                   
DefaultCluster        DefaultCluster                                                                                                                    
[root@master bin]# ./mqadmin deleteTopic -n 'master:9876' -c DefaultCluster -t test_topic
brokerAddressSet:[192.168.125.201:10911]
org.apache.rocketmq.tools.admin.DefaultMQAdminExtImpl.deleteTopicInBroker:192.168.125.201:10911
delete topic [test_topic] from cluster [DefaultCluster] success.
delete topic [test_topic] from NameServer success.
[root@master bin]# date
Thu Jul 21 07:11:33 EDT 2022
[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name         #Topic                                            #Consumer Group                                 
DefaultCluster        SCHEDULE_TOPIC_XXXX                                                                                                               
DefaultCluster        RMQ_SYS_TRANS_HALF_TOPIC                                                                                                          
DefaultCluster        DefaultCluster_REPLY_TOPIC                                                                                                        
DefaultCluster        BenchmarkTest                                                                                                                     
DefaultCluster        OFFSET_MOVED_EVENT                                                                                                                
DefaultCluster        broker-a                                                                                                                          
DefaultCluster        TBW102                                                                                                                            
DefaultCluster        SELF_TEST_TOPIC                                                                                                                   
DefaultCluster        DefaultCluster                                                                                                                    

@RongtongJin
Copy link
Contributor

Hi @JanWarlen it is necessary to remove unnecessary commit records and resolve code conflicts.

@JanWarlen
Copy link
Contributor Author

Hi @JanWarlen it is necessary to remove unnecessary commit records and resolve code conflicts.

sorry about that, i recreate another pull request.

@JanWarlen JanWarlen closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants