[ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker #4652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
mqadmin deleteTopic only request master brokers
Brief changelog
org.apache.rocketmq.tools.command.topic.DeleteTopicSubCommand#deleteTopic-- Set brokerAddressSet = CommandUtil.fetchMasterAndSlaveAddrByClusterName(adminExt, clusterName);
-- adminExt.deleteTopicInBroker(brokerAddressSet, topic);
++ Set masterBrokerAddressSet = CommandUtil.fetchMasterAddrByClusterName(adminExt, clusterName);
++ adminExt.deleteTopicInBroker(masterBrokerAddressSet, topic);
Verifying this change
I cannot exec
mvn clean package -DskipTestson branch4.9.x,so I did same change on branchrelease-4.9.4(didn't commit).And tested on my 1m-2s-sync cluster.